[BRLTTY] [PATCH] issue with status-cells on varioconnect
Mario Lang
mlang at delysid.org
Tue Nov 18 04:35:07 EST 2008
Mario Lang <mlang at delysid.org> writes:
> Andor Demarteau <andor at nl.linux.org> writes:
>
>> I've been playing around with the new cool feature of deciding my
>> statuscell layout.
>> However:
>> - the feature itself does work
>> - it takes one additional cell as seperatation which is good
>> - however, it thinks that I have 36 reading cells available as in fact
>> there are only 35 (4 status cells and 1 extra)
>> Result of this is that I'm loosing one char on every move right.
>
> I am seeing what I think is the same problem. It seems that I
> always get one extra space, no matter how I configure "Status Separator".
I think I found the problem. fillStatusSeparator() did not
check for ssNone, and since ssNone is not handled as a case
in the switch statement, we end up getting a "space" separator even
if ssNone is configured. Patch is attached.
Index: Programs/brltty.c
===================================================================
--- Programs/brltty.c (revision 4046)
+++ Programs/brltty.c (working copy)
@@ -563,7 +563,7 @@
static void
fillStatusSeparator (wchar_t *text, unsigned char *dots) {
- if (statusCount > 0) {
+ if (statusCount > 0 && prefs.statusSeparator != ssNone) {
int onRight = statusStart > 0;
unsigned int column = (onRight? statusStart: textStart) - 1;
--
CYa,
⡍⠁⠗⠊⠕ | Debian Developer <URL:http://debian.org/>
.''`. | Get my public key via finger mlang/key at db.debian.org
: :' : | 1024D/7FC1A0854909BCCDBE6C102DDFFC022A6B113E44
`. `'
`- <URL:http://delysid.org/> <URL:http://www.staff.tugraz.at/mlang/>
More information about the BRLTTY
mailing list