[BRLTTY] Dropping keyToCommand?

Mario Lang mlang at delysid.org
Mon Oct 1 11:05:24 EDT 2012


Dave Mielke <dave at mielke.cc> writes:

> [quoted lines by timothyhobbs at seznam.cz on 2012/09/23 at 21:00 +0200]
>
>>All of the function driver side(brl_keyToCommand,brl_readCommand ect) seem to 
>>take BrailleDisplay * brl as an argument.  Does this mean that the 
>>BrailleDisplay is changing?  Or is that pointer constant throughout the 
>>runtime of brltty?
>
> I hope you're not wondering if you can save it somewhere. Please don't do 
> that.
>
> Also, if you're using key tables (which you should be), the keyToCommand() et 
> al functionality isn't necessary. In fact, key tables make it quite useless 
> since the driver has no knowledge of what the commands are.

Do we have anything really using keyToCommand still?  Can't we actually
get rid of it now that we have our keyTable infrastructure, which is
clearly the better approach to the actual problem, and it appears to
confuse novice driver writers.


-- 
CYa,
  ⡍⠁⠗⠊⠕


More information about the BRLTTY mailing list