[BRLTTY] Patch: support for OCaml-4.04

Shérab Sebastien.Hinderer at ens-lyon.org
Tue Nov 8 08:46:05 EST 2016


Dear Jaroslav,

Many thinks for your patch!

I confirm it'd be good to apply it.

Thanks,

Shérab.

Jaroslav Skarvada (2016/11/08 07:58 -0500):
> Hi,
> 
> it seems that brltty-5.4 doesn't compile with OCaml-4.04.
> Tthe code uses CAMLlocal without calling CAMLparam which is against
> current OCaml documentation. More details in Fedora bug [1]. Attached
> patch should fix the problem
> 
> thanks & regards
> 
> Jaroslav
> 
> [1] https://bugzilla.redhat.com/show_bug.cgi?id=1392147

> --- a/Bindings/OCaml/brlapi_stubs.c	
> +++ a/Bindings/OCaml/brlapi_stubs.c	
> @@ -144,6 +144,7 @@ CAMLprim value brlapiml_errorCode_of_error(value camlError)
>  /* Raises the Brlapi_error exception */
>  static void raise_brlapi_error(void)
>  {
> +  CAMLparam0();
>    static value *exception = NULL;
>    CAMLlocal1(res);
>    if (exception==NULL) exception = caml_named_value("Brlapi_error");
> @@ -157,6 +158,7 @@ static void raise_brlapi_error(void)
>  /* Raises Brlapi_exception */
>  static void BRLAPI_STDCALL raise_brlapi_exception(int err, brlapi_packetType_t type, const void *packet, size_t size)
>  {
> +  CAMLparam0();
>    static value *exception = NULL;
>    int i;
>    CAMLlocal2(str, res);

> _______________________________________________
> This message was sent via the BRLTTY mailing list.
> To post a message, send an e-mail to: BRLTTY at mielke.cc
> For general information, go to: http://mielke.cc/mailman/listinfo/brltty



More information about the BRLTTY mailing list