[BRLTTY] RFE: Tcl 9.0 support?

[Jaroslav Škarvada]

On Thu, Feb 6, 2025 at 7:09 PM Dave Mielke <Dave at mielke.cc> wrote:
>
> [quoted lines by Jaroslav Škarvada on 2025/02/03 at 19:20 +0100]
>
> >there is Tcl 9.0 stable released. Is support for it planned in brltty?
>
> Are you seeing something abuot it that isn't working correctly? If tclsh is pointing to the right shell and if pkg-config reports the right version then I'd think it should be working.
>
There are multiple problems preventing it from building with Tcl-9.0.
Initially Tcl requires UTF-8, but it seems there are some sources with
old latin-9 encoding which results in the following build error:
error reading "file5": invalid or incomplete multibyte or wide character
    while executing
"gets $stream line"
    (procedure "getDependencies" line 13)
    invoked from within
"getDependencies $path"
    (procedure "getDependencies" line 35)
    invoked from within
"getDependencies $sourceFile"
    ("foreach" body line 6)
    invoked from within
"foreach sourceFile [glob -nocomplain [file join $buildDirectory
"*.$sourceExtensionsGlob"]] {
      regsub {^(\./)+} $sourceFile {} sourceFile
      i..."
    ("foreach" body line 2)
    invoked from within
"foreach buildDirectory [set buildDirectories [getBuildDirectories]] {
   foreach sourceFile [glob -nocomplain [file join $buildDirectory
"*.$sourceExt..."
    (file "Tools/gendeps" line 158)

This is trivial to fix, patch converting it to UTF-8 is attached. But
there are more problems, at least the code in bindings.c will require
porting e.g.:
./bindings.c:83:3: error: implicit declaration of function
‘Tcl_AppendStringsToObjVA’; did you mean ‘Tcl_AppendStringsToObj’?
[-Wimplicit-function-declaration]

But there may be more, because Tcl-9 has quite a lot of incompatible changes.

Full build log:
https://kojipkgs.fedoraproject.org//work/tasks/9643/129099643/build.log

thanks & regards

Jaroslav
-------------- next part --------------
A non-text attachment was scrubbed...
Name: utf8.patch
Type: text/x-patch
Size: 14909 bytes
Desc: not available
URL: <http://brltty.app/pipermail/brltty/attachments/20250210/5169f054/attachment.bin>