[BRLTTY] BrlAPI Commands

[Samuel Thibault]

Dave Mielke, le Thu 14 Dec 2006 16:57:18 -0500, a écrit :
> [quoted lines by Samuel Thibault on 2006/12/14 at 19:40 +0100]
> 
> >> (cmd | type) == cmd, at least from what I can tell.
> >
> >Then it's a bug.
> 
> I think there's just a misunderstanding here in temrs of
> expression. Yes, it is that way. The type field is included within the
> command constants.

That's actually not what I understood when we added the split of the
type part :o)

Dave Mielke, le Thu 14 Dec 2006 16:48:05 -0500, a écrit :
> This approach allows all commands to be easily handled by a single
> switch statement.

Well, for better orthogonality, shouldn't we have people check the type
separately?  A big switch can still be achieved this way:

	switch (type|command)
	case BRLAPI_KEY_TYPE_CMD|BRLAPI_KEY_CMD_LNUP:

Samuel