[BRLTTY] Reading Dots 7-8 From BrlAPI

[Dave Mielke]

[quoted lines by Rob Meredith on 2008/08/22 at 10:27 -0400]

>Knowing that you implemented supporting using the Braille Connect 12 explains 
>a lot,

We made a very conscious decision that it was better to support dots 7 and 8 
than to have extra space bars.

>I would be glad to help you determine what codes are sent for the specific dot 
>7 and 8 keys on the Connect 24, but I need pretty specific instructions!

No problem. Why not try guessing first, though. Could you please try the 
attached patch (baum-dots78-1.patch) and let me know if it works? I don't know 
which revision of brltty you're using. This patch is against the development 
stream but should also work for release 3.10.

-- 
Dave Mielke           | 2213 Fox Crescent | I believe that the Bible is the
Phone: 1-613-726-0014 | Ottawa, Ontario   | Word of God. Please contact me
EMail: dave at mielke.cc | Canada  K2A 1H7   | if you're concerned about Hell.
http://FamilyRadio.com/                   | http://Mielke.cc/bible/
-------------- next part --------------
Index: BrailleDrivers/Baum/braille.c
===================================================================
--- BrailleDrivers/Baum/braille.c	(revision 3915)
+++ BrailleDrivers/Baum/braille.c	(working copy)
@@ -447,23 +447,25 @@
 #define BAUM_KEY_BLU BAUM_KEY(0X20, BACK6)
 
 #define BAUM_SHIFT_DOT (BAUM_SHIFT_BACK10A + BAUM_WIDTH_BACK10A)
-#define BAUM_WIDTH_DOT 6
+#define BAUM_WIDTH_DOT 8
 #define BAUM_KEY_DOT1 BAUM_KEY(0X01, DOT)
 #define BAUM_KEY_DOT2 BAUM_KEY(0X02, DOT)
 #define BAUM_KEY_DOT3 BAUM_KEY(0X04, DOT)
 #define BAUM_KEY_DOT4 BAUM_KEY(0X08, DOT)
 #define BAUM_KEY_DOT5 BAUM_KEY(0X10, DOT)
 #define BAUM_KEY_DOT6 BAUM_KEY(0X20, DOT)
+#define BAUM_KEY_DOT7 BAUM_KEY(0X40, DOT)
+#define BAUM_KEY_DOT8 BAUM_KEY(0X80, DOT)
 
 #define BAUM_SHIFT_BUTTON (BAUM_SHIFT_DOT + BAUM_WIDTH_DOT)
-#define BAUM_WIDTH_BUTTON 8
-#define BAUM_KEY_B9  BAUM_KEY(0X01, BUTTON)
-#define BAUM_KEY_B0  BAUM_KEY(0X02, BUTTON)
-#define BAUM_KEY_B11 BAUM_KEY(0X04, BUTTON)
-#define BAUM_KEY_F1  BAUM_KEY(0X10, BUTTON)
-#define BAUM_KEY_F2  BAUM_KEY(0X20, BUTTON)
-#define BAUM_KEY_F3  BAUM_KEY(0X40, BUTTON)
-#define BAUM_KEY_F4  BAUM_KEY(0X80, BUTTON)
+#define BAUM_WIDTH_BUTTON 7
+#define BAUM_KEY_F1  BAUM_KEY(0X01, BUTTON)
+#define BAUM_KEY_F2  BAUM_KEY(0X02, BUTTON)
+#define BAUM_KEY_F3  BAUM_KEY(0X04, BUTTON)
+#define BAUM_KEY_F4  BAUM_KEY(0X08, BUTTON)
+#define BAUM_KEY_B9  BAUM_KEY(0X10, BUTTON)
+#define BAUM_KEY_B0  BAUM_KEY(0X20, BUTTON)
+#define BAUM_KEY_B11 BAUM_KEY(0X40, BUTTON)
 
 #define BAUM_SHIFT_JOYSTICK (BAUM_SHIFT_BUTTON + BAUM_WIDTH_BUTTON)
 #define BAUM_WIDTH_JOYSTICK 5
@@ -2207,6 +2209,7 @@
   } else if (routingKeyCount == 0) {
     if (keys && (keys == (keys & (BAUM_KEY_DOT1 | BAUM_KEY_DOT2 | BAUM_KEY_DOT3 |
                                   BAUM_KEY_DOT4 | BAUM_KEY_DOT5 | BAUM_KEY_DOT6 |
+                                  BAUM_KEY_DOT7 | BAUM_KEY_DOT8 |
                                   BAUM_KEY_B9 | BAUM_KEY_B0)))) {
       command = BRL_BLK_PASSDOTS;
 #define DOT(dot,key) if (keys & BAUM_KEY_##key) command |= BRL_DOT##dot
@@ -2216,6 +2219,8 @@
       DOT(4, DOT4);
       DOT(5, DOT5);
       DOT(6, DOT6);
+      DOT(7, DOT7);
+      DOT(8, DOT8);
       DOT(7, B9);
       DOT(8, B0);
 #undef DOT