[BRLTTY] [patch] fix the api socket directory

William Hubbs w.d.hubbs at gmail.com
Sat May 16 18:49:56 EDT 2009


Hi Samuel and all,

On Sat, May 16, 2009 at 10:11:41PM +0200, Samuel Thibault wrote:
> William Hubbs, le Sat 16 May 2009 14:56:23 -0500, a ?crit :
> > In configure.ac, api_socket_path is set so that when the directory is
> > created it is /var/lib/lib/brltty.
> > -      api_socket_path="${localstatedir}/lib/BrlAPI"
> > +      api_socket_path="${localstatedir}/BrlAPI"
> 
> ?!
> localstatedir is /var, so adding lib is needed here. Else you'd end up
> with /var/BrlAPI.
 
 Ok, I can correct this at our level without a patch.  The issue is that
 our default for calling ./configure sets localstatedir to /var/lib, and
 when we do this, the result is that /var/lib/lib/brltty gets created.

 Attached below is the patch that makes the api socket directory respect
 INSTALL_ROOT.

 Thanks,

 William


-------------- next part --------------
Index: common.mk
===================================================================
--- common.mk	(revision 4484)
+++ common.mk	(working copy)
@@ -74,8 +74,9 @@
 install-apihdr-directory:
 	$(INSTALL_DIRECTORY) $(INSTALL_APIHDR_DIRECTORY)
 
+INSTALL_API_SOCKET_DIRECTORY = $(INSTALL_ROOT)$(API_SOCKET_DIRECTORY)
 install-apisoc-directory:
-	-$(INSTALL_DIRECTORY) -m 1777 $(API_SOCKET_DIRECTORY)
+	-$(INSTALL_DIRECTORY) -m 1777 $(INSTALL_API_SOCKET_DIRECTORY)
 
 clean::
 	-rm -f *.$O *.auto.h *.auto.c core implib.a
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
Url : http://mielke.cc/pipermail/brltty/attachments/20090516/16826525/attachment.bin 


More information about the BRLTTY mailing list