[BRLTTY] [patch] allow authentication via polkit

Samuel Thibault samuel.thibault at ens-lyon.org
Thu Jan 28 17:05:10 EST 2016


Hello,

Mike Gorse, on Thu 28 Jan 2016 10:22:41 -0500, wrote:
> It shouldn't have any effect unless Auth=polkit is passed.

Mmm, I wonder whether we shouldn't want to make this the default?  I.e.
extend the auth syntax to include several authentication possibilities,
and include both the authkey file and auth=polkit.

> - I could probably rework the patch to only use libdbus, rather than
> polkit-gobject, if people would prefer that.

It's mostly a question for distributions. It's true that a standard
Debian system doesn't have libglib installed. That's only 5MiB however,
and the print task depends on it for instance. So I'd tend to think it
won't be a problem.

> --- a/Programs/brlapi_protocol.h
> +++ b/Programs/brlapi_protocol.h
> @@ -103,8 +103,8 @@ typedef struct {
>  } brlapi_authServerPacket_t;
>  
>  #define BRLAPI_AUTH_NONE 'N' /**< No or implicit authorization              */
> -#define BRLAPI_AUTH_KEY  'K' /**< Key authorization                         */
> -#define BRLAPI_AUTH_CRED 'C' /**< Explicit socket credentials authorization */
> +#define BRLAPI_AUTH_KEY    'K' /**< Key authorization                         */
> +#define BRLAPI_AUTH_CRED   'C' /**< Explicit socket credentials authorization */
>  
>  /** Structure of error packets */
>  typedef struct {

No need for a protocol change indeed, you can drop this spurious trivial change.

Samuel


More information about the BRLTTY mailing list