[BRLTTY] Adding support for new HumanWare devices

[Étienne Carrier]

Hello, I found two things this morning while browsing the project

First I've realised that we added the BI20X with support for the command keys but the BI20X doesn't have command keys. Here's a patch to remove them (tried to push to the branch but I wasn't able to, maybe the branch is protected) :

diff --git a/Drivers/Braille/HumanWare/braille.c b/Drivers/Braille/HumanWare/braille.c
index fdae2ddc1..1cbc11a2e 100644
--- a/Drivers/Braille/HumanWare/braille.c
+++ b/Drivers/Braille/HumanWare/braille.c
@@ -136,7 +136,6 @@ BEGIN_KEY_NAME_TABLES(BI20X)
   KEY_NAME_TABLE(routing),
   KEY_NAME_TABLE(thumb),
   KEY_NAME_TABLE(braille),
-  KEY_NAME_TABLE(command),
 END_KEY_NAME_TABLES
 
 DEFINE_KEY_TABLE(BI14)
@@ -248,7 +247,6 @@ static const ModelEntry modelEntry_BI40X = {
 static const ModelEntry modelEntry_BI20X = {
   .modelName = "Brailliant BI 20X",
   .hasBrailleKeys = 1,
-  .hasCommandKeys = 1,
   .keyTableDefinition = &KEY_TABLE_DEFINITION(BI20X)
 };
 
diff --git a/Tables/Input/hw/BI20X.ktb b/Tables/Input/hw/BI20X.ktb
index cc8f68898..63589ebaf 100644
--- a/Tables/Input/hw/BI20X.ktb
+++ b/Tables/Input/hw/BI20X.ktb
@@ -20,5 +20,4 @@ title HumanWare Brailliant BI 20X
 
 include thumb.kti
 include braille.kti
-include command.kti
 include routing.kti

Second thing is that the table folder for HumanWare might be missing a BI40X.ktb, unless you somehow use the same table file for the BI40 ( and the Tables/Input/hw/BI40.ktb) and the BI40.

I have more time this morning, I'll try to investigate the lagging issue on the BI40X. I'll do some testing with other screen reader just to be sure.

Thanks again for your help.

-----Message d'origine-----
De : BRLTTY <brltty-bounces at brltty.app> De la part de Dave Mielke
Envoyé : 3 août 2021 19:52
À : Informal discussion between users and developers of BRLTTY. <brltty at brltty.app>
Objet : Re: [BRLTTY] Adding support for new HumanWare devices

[quoted lines by Justin Pospical on 2021/08/03 at 16:28 -0700]

>Doesn't seem to be working with my Chameleon 20 connected via bluetooth, which I think is basically the same device.

Yes. That's because these models only use Bluetooth HID, i.e. they don't support Bluetooth serial, and brltty doesn't support Bluetooth HID yet.

--
I believe the Bible to be the very Word of God: https://can01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fmielke.cc%2Fbible%2F&data=04%7C01%7C%7C2d260a840fbd4c6be7ad08d956d9c03f%7Ca20dee1502224c59b520fa220fd6eb14%7C0%7C0%7C637636317304802733%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=abOOqWQyku2sfnCfJXPwz4YZnqc6d9SfLnbtHUL%2Frxw%3D&reserved=0
Dave Mielke            | 2213 Fox Crescent | WebHome: https://can01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fmielke.cc%2F&data=04%7C01%7C%7C2d260a840fbd4c6be7ad08d956d9c03f%7Ca20dee1502224c59b520fa220fd6eb14%7C0%7C0%7C637636317304802733%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=%2FEf3P3ECHHHxC1oVXW0M9YDyLy9zMZ2dY%2FPmD0FXkEs%3D&reserved=0
EMail: Dave at Mielke.cc  | Ottawa, Ontario   | Twitter: @Dave_Mielke
Phone: +1 613 726 0014 | Canada  K2A 1H7   |
_______________________________________________
This message was sent via the BRLTTY mailing list.
To post a message, send an e-mail to: BRLTTY at brltty.app For general information, go to: https://can01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fbrltty.app%2Fmailman%2Flistinfo%2Fbrltty&data=04%7C01%7C%7C2d260a840fbd4c6be7ad08d956d9c03f%7Ca20dee1502224c59b520fa220fd6eb14%7C0%7C0%7C637636317304802733%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=2JCpSIGU59LK44KAKLt4QNmiTWiEv60ga83qW2Gk2xs%3D&reserved=0