[BRLTTY] Nits in configure.ac
Stepan Kasal
kasal at ucw.cz
Mon Aug 27 11:03:50 EDT 2007
Hello,
when reviewing a packaging issue in Fedora GNU/Linux, I noticed a nit
in your Autoconf usage.
Your configure.ac uses changequote(), which is not recommended by the
Autoconf manual and clutters the code.
It's much safer and nicer to use quoting: when a string is inside a
pair of brackets, it's not expanded by m4.
So I suggest to apply the patch attached to this mail.
Thanks for your time,
Stepan Kasal
-------------- next part --------------
2007-08-21 Stepan Kasal <kasal at ucw.cz>
* configure.ac: Use quoting, not changequote().
--- brltty-3.8/configure.ac 2007-06-04 15:20:43.000000000 +0200
+++ brltty-3.8.new/configure.ac 2007-08-21 17:56:44.000000000 +0200
@@ -1439,11 +1439,9 @@
AC_SUBST([install_drivers])
BRLTTY_SUMMARY_END
-changequote(, )dnl
-brltty_make_files="`echo "${brltty_build_directories}" | sed -e '
+[brltty_make_files="`echo "${brltty_build_directories}" | sed -e '
s%\([^ ][^ ]*\)%\1/Makefile:prologue.mk.in:\1/Makefile.in%g
-'`"
-changequote([, ])dnl
+'`"]
AC_OUTPUT([
config.mk
More information about the BRLTTY
mailing list