[BRLTTY] BRLTTY crash

[Sebastian Humenda]

Hi

Sebastian Humenda schrieb am 23.09.2016, 21:23 +0200:
>I'm experiencing repeated crashes of BRLTTY. I cannot be more precise about the
>context in which the crash occurs, since I'm having multiple issues with BRLTTY
>at the moment.
>I've taken back traces from three crashes which happened shortly one after
[...]
I was able to hunt down the cause. Speech Dispatcher is not started on my system
automatically. In the asynchronous_event.c, a pointer is supplied to the event
handler function, but it's not checked for null. I've inserted the check and I
have not seen a crash until now.
Please let me know whether the check is at the appropriate place and consider
including the patch.

Thanks!
Sebastian
-- 
Web: http://www.crustulus.de (English|Deutsch)  | Blog: http://www.crustulus.de/blog
FreeDict: Free multilingual dictionaries - http://www.freedict.org
Freies Latein-Deutsch-Wörterbuch: http://www.crustulus.de/freedict.de.html
-------------- next part --------------
Index: brltty-patchspeech/Programs/async_event.c
===================================================================
--- brltty-patchspeech.orig/Programs/async_event.c
+++ brltty-patchspeech/Programs/async_event.c
@@ -75,7 +75,11 @@ ASYNC_MONITOR_CALLBACK(asyncMonitorEvent
 int
 asyncSignalEvent (AsyncEvent *event, void *data) {
   const size_t size = sizeof(data);
-  ssize_t result = writeFileDescriptor(event->pipeInput, &data, size);
+  ssize_t result;
+  if (event != NULL)
+    result = writeFileDescriptor(event->pipeInput, &data, size);
+  else
+    result = -1;
 
   if (result == size) {
 #ifdef __MINGW32__
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://mielke.cc/pipermail/brltty/attachments/20160924/d0205ff8/attachment.sig>