[BRLTTY] Backspace (dot7) and Enter (dot8) on Fedora 33

Samuel Thibault samuel.thibault at ens-lyon.org
Wed Dec 23 06:05:33 EST 2020


Frans-WIllem Post, le mer. 23 déc. 2020 09:44:59 +0100, a ecrit:
> See attached log file.

Ok, I see, I believe I have fixed this with the attached patch, could
you try it?

Samuel
-------------- next part --------------
commit 67b9d27f7707a0f46d96de5d96c1b164754cb11f
Author: Samuel Thibault <samuel.thibault at ens-lyon.org>
Date:   Wed Dec 23 12:01:31 2020 +0100

    brlapi: Fix backspace synthesis in xbrlapi
    
    Even if the alternate code without retaindot is the same as the code
    with retaindot, we need to call whoGetsKey. Otherwise xbrlapi does not
    get backspace keycodes: they produce the same keycode with/without
    retaindot, but since xbrlapi sets retaindot to 0, it would not get them
    from the first call.

diff --git a/Programs/brlapi_server.c b/Programs/brlapi_server.c
index 0898e5ef6..cfa19563e 100644
--- a/Programs/brlapi_server.c
+++ b/Programs/brlapi_server.c
@@ -4109,11 +4109,9 @@ static int api__handleCommand(int command) {
       if (!cmdBrlttyToBrlapi(&alternate, command, 0)) {
 	logMessage(LOG_CATEGORY(SERVER_EVENTS), "command %08x could not be converted to BrlAPI without retainDots", command);
       } else {
-	if (alternate != code) {
-	  logMessage(LOG_CATEGORY(SERVER_EVENTS), "command %08x -> client code %016"BRLAPI_PRIxKEYCODE, command, alternate);
-	  c = whoGetsKey(&ttys, alternate, BRL_COMMANDS, 0);
-	  if (c) code = alternate;
-	}
+	logMessage(LOG_CATEGORY(SERVER_EVENTS), "command %08x -> client code %016"BRLAPI_PRIxKEYCODE, command, alternate);
+	c = whoGetsKey(&ttys, alternate, BRL_COMMANDS, 0);
+	if (c) code = alternate;
       }
     }
 


More information about the BRLTTY mailing list